Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dump metrics #3488

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: support dump metrics #3488

merged 2 commits into from
Jan 7, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 31, 2024

No description provided.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 184 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (db950cf) to head (9492ba1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
metrics/metrics_dump.go 32.11% 122 Missing and 7 partials ⚠️
internal/server/metrics_init.go 0.00% 38 Missing ⚠️
internal/conf/path.go 17.65% 13 Missing and 1 partial ⚠️
internal/conf/conf.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
- Coverage   71.34%   71.07%   -0.27%     
==========================================
  Files         415      416       +1     
  Lines       47825    48001     +176     
==========================================
- Hits        34118    34113       -5     
- Misses      11038    11218     +180     
- Partials     2669     2670       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer marked this pull request as ready for review January 6, 2025 04:58
@Yisaer Yisaer requested a review from yiqunc-emqx as a code owner January 6, 2025 04:58
@Yisaer Yisaer requested a review from ngjaying January 6, 2025 04:58
Signed-off-by: Song Gao <[email protected]>
@ngjaying ngjaying merged commit 0c6f4a0 into lf-edge:master Jan 7, 2025
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants